Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver

[Guenter Roeck]

On 7/6/20 4:54 AM, Timothy Myers wrote:
> 
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Guenter Roeck <groeck7@xxxxxxxxx> on behalf of Guenter Roeck <linux@xxxxxxxxxxxx>
> *Sent:* Friday, June 26, 2020 4:51 PM
> *To:* Timothy Myers <timothy.myers@xxxxxxxxxx>
> *Cc:* Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>; linux-watchdog@xxxxxxxxxxxxxxx <linux-watchdog@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; David Boike <david.boike@xxxxxxxxxx>
> *Subject:* Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver
>  
> On Fri, Jun 26, 2020 at 01:39:43PM +0000, Timothy Myers wrote:
>> Add the common "nowayout" parameter to booke_wdt to make this behavior
>> selectable at runtime and to make the implementation more consistent with
>> many other watchdog drivers.
>>
>> Signed-off-by: Timothy Myers <timothy.myers@xxxxxxxxxx>
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> Hello,
>     I also have a similar question as Tiezhu recently. Now that this patch has been reviewed, what is the next step?
> Thank you,
> Tim Myers

Interesting. The other patch is in my -next tree, and I plan to send a pull
request to Wim shortly. However, patchwork has no record of your patch.
Since I apply patches from patchwork, it effectively got lost. Please resend,
preferably with my Reviewed-by: tag.

Guenter

> 
>> ---
>> drivers/watchdog/booke_wdt.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
>> index 9d09bbfdef20..7817fb976f9c 100644
>> --- a/drivers/watchdog/booke_wdt.c
>> +++ b/drivers/watchdog/booke_wdt.c
>> @@ -39,6 +39,11 @@ static bool booke_wdt_enabled;
>> module_param(booke_wdt_enabled, bool, 0);
>> static int booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT;
>> module_param(booke_wdt_period, int, 0);
>> +static bool nowayout = WATCHDOG_NOWAYOUT;
>> +module_param(nowayout, bool, 0);
>> +MODULE_PARM_DESC(nowayout,
>> + "Watchdog cannot be stopped once started (default="
>> + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>>
>> #ifdef CONFIG_PPC_FSL_BOOK3E
>>
>> @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void)
>> static int __init booke_wdt_init(void)
>> {
>> int ret = 0;
>> - bool nowayout = WATCHDOG_NOWAYOUT;
>>
>> pr_info("powerpc book-e watchdog driver loaded\n");
>> booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;
>>
>> base-commit: dd0d718152e4c65b173070d48ea9dfc06894c3e5
>> --
>> 2.20.1
>>
>>
>>
>> Timothy Myers
>> Software Design Engineer
>>
>> Office: 256.963.8844
>> Email: timothy.myers@xxxxxxxxxx<https://owa.adtran.com/owa/redir.aspx?C=LNINRERj1VQgAKE9UNiu-b2J50yb_mKuK9OX8J4spjQqMzmAKlzUCA..&URL=mailto%3atom.patterson%40adtran.com <https://protect-us.mimecast.com/s/hhcoC73VkBhE3L6nFN4I06?domain=owa.adtran.com>>
>> Web: www.adtran.com <https://protect-us.mimecast.com/s/Fe38C82KlDFOn9MBFobOrH?domain=adtran.com><https://owa.adtran.com/owa/redir.aspx?C=AO4_0fpgN4Gmyy4bPe0sTxLKfRJry5Qrse3aJSw01zEqMzmAKlzUCA..&URL=http%3a%2f%2fs.bl-1.com%2fh%2fCoY1mz9%3furl%3dhttp%3a%2f%2fwww.adtran.com <https://protect-us.mimecast.com/s/pXgyC9rYmEuRo8KrU1uzSh?domain=owa.adtran.com>>
>>
>> ADTRAN
>> 901 Explorer Boulevard
>> Huntsville, AL 35806 - USA