Re: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU

From: Daniel Baluta
Date: Mon Jul 06 2020 - 11:12:33 EST



On 06.07.2020 18:00, Vincenzo Frascino wrote:
imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only
when CONFIG_PM_SLEEP configuration options is enabled. Having it
disabled triggers the following warning at compile time:

drivers/mailbox/imx-mailbox.c:611:12: warning: âimx_mu_resume_noirqâ
defined but not used [-Wunused-function]
static int imx_mu_resume_noirq(struct device *dev)

drivers/mailbox/imx-mailbox.c:601:12: warning: âimx_mu_suspend_noirqâ
defined but not used [-Wunused-function]
static int imx_mu_suspend_noirq(struct device *dev)

Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to
address the issue.

Cc: Jassi Brar <jassisinghbrar@xxxxxxxxx>
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
Cc: Fabio Estevam <festevam@xxxxxxxxx>
Cc: NXP Linux Team <linux-imx@xxxxxxx>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>