Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'
From: Eric W. Biederman
Date: Mon Jul 06 2020 - 13:01:13 EST
Lee Jones <lee.jones@xxxxxxxxxx> writes:
> 'ret' hasn't been checked since the driver's inception in 2009.
Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port
early console, v4") in July of 2008.
Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/usb/early/ehci-dbgp.c: In function âearly_dbgp_writeâ:
> drivers/usb/early/ehci-dbgp.c:915:13: warning: variable âretâ set but not used [-Wunused-but-set-variable]
> 915 | int chunk, ret;
> | ^~~
>
> Cc: Sumit Garg <sumit.garg@xxxxxxxxxx>
> Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Petr Mladek <pmladek@xxxxxxxx>
> Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Cc: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
> Cc: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/usb/early/ehci-dbgp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
> index 775cf70cfb3ed..b075dbfad730f 100644
> --- a/drivers/usb/early/ehci-dbgp.c
> +++ b/drivers/usb/early/ehci-dbgp.c
> @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s)
>
> static void early_dbgp_write(struct console *con, const char *str, u32 n)
> {
> - int chunk, ret;
> + int chunk;
> char buf[DBGP_MAX_PACKET];
> int use_cr = 0;
> u32 cmd, ctrl;
> @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n)
> buf[chunk] = *str;
> }
> if (chunk > 0) {
> - ret = dbgp_bulk_write(USB_DEBUG_DEVNUM,
> - dbgp_endpoint_out, buf, chunk);
> + dbgp_bulk_write(USB_DEBUG_DEVNUM,
> + dbgp_endpoint_out, buf, chunk);
> }
> }
> if (unlikely(reset_run)) {