Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages

[Harry Cutts]

On Sun, 5 Jul 2020 at 10:09, Maciej S. Szmigiero
<mail@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> These messages appear each time the mouse wakes from sleep, in my case
> (Logitech M705), every minute or so.
> Let's downgrade them to the "debug" level so they don't fill the kernel log
> by default.
>
> While we are at it, let's make clear that this is a wheel multiplier (and
> not, for example, XY movement multiplier).

Looks good to me, thanks!

Reviewed-by: Harry Cutts <hcutts@xxxxxxxxxxxx>

Harry Cutts
Chrome OS Touch/Input team

>
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Maciej S. Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 1e1cf8eae649..b8b53dc95e86 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp)
>                 multiplier = 1;
>
>         hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
> -       hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
> +       hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
>         return 0;
>  }
>