Re: mmotm 2020-07-06-18-53 uploaded (sound/soc/amd/renoir/rn-pci-acp3x.c:)

[Randy Dunlap]

On 7/6/20 11:15 PM, Mukunda,Vijendar wrote:
> 
> 
> On 07/07/20 11:14 am, Randy Dunlap wrote:
>> On 7/6/20 6:53 PM, Andrew Morton wrote:
>>> The mm-of-the-moment snapshot 2020-07-06-18-53 has been uploaded to
>>>
>>> ÂÂÂ https://nam11.safelinks.protection.outlook.com/?url=http:%2F%2Fwww.ozlabs.org%2F~akpm%2Fmmotm%2F&data=02%7C01%7CVijendar.Mukunda%40amd.com%7C34f06090b5394f9ccb9d08d82238c5cf%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637296974530250787&sdata=K8z5g9P5S7Ct%2BojnITdP0xuz159sYOiDWOyUy3abDpo%3D&reserved=0
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> https://nam11.safelinks.protection.outlook.com/?url=http:%2F%2Fwww.ozlabs.org%2F~akpm%2Fmmotm%2F&data=02%7C01%7CVijendar.Mukunda%40amd.com%7C34f06090b5394f9ccb9d08d82238c5cf%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637296974530250787&sdata=K8z5g9P5S7Ct%2BojnITdP0xuz159sYOiDWOyUy3abDpo%3D&reserved=0
>>>
>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release (5.x
>>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
>>> https://nam11.safelinks.protection.outlook.com/?url=http:%2F%2Fozlabs.org%2F~akpm%2Fmmotm%2Fseries&data=02%7C01%7CVijendar.Mukunda%40amd.com%7C34f06090b5394f9ccb9d08d82238c5cf%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637296974530250787&sdata=6CpbYkoZTJ%2FxqhyFKdZMjH%2BdG5kjOgogt8KqqNK%2BzSI%3D&reserved=0
>>>
>>
>> on i386:
>>
>> when CONFIG_ACPI is not set/enabled:
>>
>> ../sound/soc/amd/renoir/rn-pci-acp3x.c: In function âsnd_rn_acp_probeâ:
>> ../sound/soc/amd/renoir/rn-pci-acp3x.c:222:9: error: implicit declaration of function âacpi_evaluate_integerâ; did you mean âacpi_evaluate_objectâ? [-Werror=implicit-function-declaration]
>> ÂÂÂ ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
> Will add ACPI as dependency in Kconfig for Renoir ACP driver.
> Do i need to upload new version of the patch? or should i submit the incremental patch as a fix >> ÂÂÂÂÂÂÂÂÂ ^~~~~~~~~~~~~~~~~~~~~
>> ÂÂÂÂÂÂÂÂÂ acpi_evaluate_object

Hi,
Not my call, but I would go with an incremental patch.


thanks.
-- 
~Randy