Re: [PATCH v2 4/6] selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan

[Paolo Bonzini]

On 06/07/20 22:55, Shuah Khan wrote:
> On 6/24/20 12:21 AM, Paolo Bonzini wrote:
>> On 23/06/20 22:44, Christian Brauner wrote:
>>>> ÂÂÂÂÂ ret = sys_pidfd_send_signal(pidfd, 0, NULL, 0);
>>>> ÂÂÂÂÂ if (ret < 0) {
>>>> -ÂÂÂÂÂÂÂ if (errno == ENOSYS)
>>>> -ÂÂÂÂÂÂÂÂÂÂÂ ksft_exit_skip(
>>>> +ÂÂÂÂÂÂÂ if (errno == ENOSYS) {
>>>> +ÂÂÂÂÂÂÂÂÂÂÂ ksft_test_result_skip(
>>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "%s test: pidfd_send_signal() syscall not
>>>> supported\n",
>>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ test_name);
>>> If pidfd_send_signal() is not supported, you're falling through and then
>>> you're reporting:
>>>
>>> ok 5 # SKIP pidfd_send_signal check for support test:
>>> pidfd_send_signal() syscall not supported
>>> ok 6 pidfd_send_signal check for support test: pidfd_send_signal()
>>> syscall is supported. Tests can be executed
>>
>> You're right, this needs a "return".
>>
> 
> Hi Paulo,
> 
> I am applying the rest of the patches in this series except this one.
> Please send v3 for this.

Thanks, I was actually going to send everything but you're making it
even simpler.  I'll send v3 of this patch only.

Paolo