Re: [PATCH net-next] hinic: add firmware update support

[luobin (L)]

On 2020/7/7 0:57, Jakub Kicinski wrote:
> On Mon, 6 Jul 2020 22:54:06 +0800 Luo bin wrote:
>> add support to update firmware with with "ethtool -f" cmd
>>
>> Signed-off-by: Luo bin <luobin9@xxxxxxxxxx>
> 
> drivers/net/ethernet/huawei/hinic/hinic_ethtool.c:1996:44: warning: missing braces around initializer
> drivers/net/ethernet/huawei/hinic/hinic_ethtool.c:1996:44: warning: missing braces around initializer
> 
> But really - please try to implement the devlink flashing API, using
> ethtool for this is deprecated.
> .
> 
Okay. Will fix. Thanks for your review.