Re: [PATCH] ASoC: amd: add ACPI dependency check

[Randy Dunlap]

On 7/7/20 7:17 AM, Mark Brown wrote:
> On Tue, 7 Jul 2020 16:16:41 +0530, Vijendar Mukunda wrote:
>> Add ACPI dependency for evaluating DMIC hardware
>> runtime.
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: amd: add ACPI dependency check
>       commit: 68d1abe186d1c865923d3b97414906f4697daf58
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.


Vijendar, you should have Cc-ed me on the patch and you should have
added this line to the patch:

Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Also, now
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

although there are now 2 warnings:

../sound/soc/amd/renoir/rn-pci-acp3x.c: In function âsnd_rn_acp_probeâ:
../sound/soc/amd/renoir/rn-pci-acp3x.c:172:15: warning: unused variable âdmic_statusâ [-Wunused-variable]
  acpi_integer dmic_status;
               ^~~~~~~~~~~
../sound/soc/amd/renoir/rn-pci-acp3x.c:171:14: warning: unused variable âhandleâ [-Wunused-variable]
  acpi_handle handle;
              ^~~~~~



thanks.
-- 
~Randy