Re: [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush()

[David Hildenbrand]

On 07.07.20 18:32, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> 
> 'addr' is set to 'start' and then a few lines afterwards 'start' is
> set to 'addr'.
> Remove the second asignment.
> 
> Fixes: 2ba3e6947aed ("mm/vmalloc: track which page-table levels were modified")
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> ---
>  mm/vmalloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 5a2b55c8dd9a..68ebbafc9c9b 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -171,11 +171,10 @@ void unmap_kernel_range_noflush(unsigned long start, unsigned long size)
>  	pgd_t *pgd;
>  	unsigned long addr = start;
>  	pgtbl_mod_mask mask = 0;
>  
>  	BUG_ON(addr >= end);
> -	start = addr;
>  	pgd = pgd_offset_k(addr);
>  	do {
>  		next = pgd_addr_end(addr, end);
>  		if (pgd_bad(*pgd))
>  			mask |= PGTBL_PGD_MODIFIED;
> 

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 
Thanks,

David / dhildenb