Re: [PATCH] net: atlantic: Add support for firmware v4

[David Miller]

From: Alexander Lobakin <alobakin@xxxxxxxxxxx>
Date: Tue, 7 Jul 2020 11:46:57 +0300

> From:   Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> Date:   Tue,  7 Jul 2020 14:38:28 +0800
> 
>> We have a new ethernet card that is supported by the atlantic driver:
>> 01:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE 802.3bz Ethernet Controller [AQtion] [1d6a:07b1] (rev 02)
>> 
>> But the driver failed to probe the device:
>> kernel: atlantic: Bad FW version detected: 400001e
>> kernel: atlantic: probe of 0000:01:00.0 failed with error -95
>> 
>> As a pure guesswork, simply adding the firmware version to the driver
> 
> Please don't send "pure guessworks" to net-fixes tree. You should have
> reported this as a bug to LKML and/or atlantic team, so we could issue
> it.

Production hardware is shipping to customers and the driver
maintainers didn't add support for this ID yet?  What is that
"atlantic team" waiting for?

Honestly I don't blame someone for posting a patch like this to get it
to work.