[PATCH] nvme-pci: use standard block status symbolic names to check return value

From: Baolin Wang
Date: Tue Jul 07 2020 - 22:19:46 EST


It's better to use the same symbol as the return to check return value,
and will always work in the unlikely event that the defines are reordered.

Suggested-by: Keith Busch <kbusch@xxxxxxxxxx>
Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
---
drivers/nvme/host/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1ac0717..45cb59c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -873,18 +873,18 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
return BLK_STS_IOERR;

ret = nvme_setup_cmd(ns, req, &cmnd);
- if (ret)
+ if (ret != BLK_STS_OK)
return ret;

if (blk_rq_nr_phys_segments(req)) {
ret = nvme_map_data(dev, req, &cmnd);
- if (ret)
+ if (ret != BLK_STS_OK)
goto out_free_cmd;
}

if (blk_integrity_rq(req)) {
ret = nvme_map_metadata(dev, req, &cmnd);
- if (ret)
+ if (ret != BLK_STS_OK)
goto out_unmap_data;
}

--
1.8.3.1