Re: [PATCH] xfs: Use fallthrough pseudo-keyword

From: Dave Chinner
Date: Wed Jul 08 2020 - 02:55:19 EST


On Tue, Jul 07, 2020 at 06:48:29PM -0700, Joe Perches wrote:
> On Tue, 2020-07-07 at 13:50 -0700, Darrick J. Wong wrote:
> > On Tue, Jul 07, 2020 at 03:05:04PM -0500, Gustavo A. R. Silva wrote:
> > > Replace the existing /* fall through */ comments and its variants with
> > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > > fall-through markings when it is the case.
> []
> > I don't get it, what's the point? Are gcc/clang
> > refusing to support -Wimplicit-fallthrough=[1-4] past a certain date?
>
> clang doesn't support comments

So fix the damn compiler.

-Dave
--
Dave Chinner
david@xxxxxxxxxxxxx