Re: [PATCH 00/10] Fix a bunch SCSI related W=1 warnings

[Damien Le Moal]

On 2020/07/08 15:51, Lee Jones wrote:
> On Wed, 08 Jul 2020, Damien Le Moal wrote:
> 
>> On 2020/07/07 23:01, Lee Jones wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>>
>>> There are a whole lot more of these.  More fixes to follow.
>>
>> Hi Lee,
>>
>> I posted a series doing that cleanup for megaraid, mpt3sas sd and sd_zbc yesterday.
>>
>> https://www.spinics.net/lists/linux-scsi/msg144023.html
>>
>> Probably could merge the series since yours touches other drivers too.
> 
> Do you have plans to fix anything else, or should I continue?

I only fixed the warnings for the drivers enabled on my test setup. No real plan
to continue with other drivers for now.

My series did not touch aha, pcmcia and libfc, so these should still apply.

> 
>>> Lee Jones (10):
>>>   scsi: megaraid: megaraid_mm: Strip excess function param description
>>>   scsi: megaraid: megaraid_mbox: Fix some kerneldoc bitrot
>>>   scsi: fdomain: Mark 'fdomain_pm_ops' as __maybe_unused
>>>   scsi: megaraid: megaraid_sas_fusion: Fix-up a whole myriad of
>>>     kerneldoc misdemeanours
>>>   scsi: megaraid: megaraid_sas_base: Provide prototypes for non-static
>>>     functions
>>>   scsi: aha152x: Remove unused variable 'ret'
>>>   scsi: pcmcia: nsp_cs: Use new __printf() format notation
>>>   scsi: pcmcia: nsp_cs: Remove unused variable 'dummy'
>>>   scsi: libfc: fc_disc: Fix-up some incorrectly referenced function
>>>     parameters
>>>   scsi: megaraid: megaraid_sas: Convert forward-declarations to
>>>     prototypes
>>>
>>>  drivers/scsi/aha152x.c                      |   3 +-
>>>  drivers/scsi/fdomain.h                      |   2 +-
>>>  drivers/scsi/libfc/fc_disc.c                |   6 +-
>>>  drivers/scsi/megaraid/megaraid_mbox.c       |   4 +-
>>>  drivers/scsi/megaraid/megaraid_mm.c         |   1 -
>>>  drivers/scsi/megaraid/megaraid_sas.h        |  25 ++++-
>>>  drivers/scsi/megaraid/megaraid_sas_base.c   |   4 -
>>>  drivers/scsi/megaraid/megaraid_sas_fusion.c | 102 ++++++++------------
>>>  drivers/scsi/megaraid/megaraid_sas_fusion.h |   6 ++
>>>  drivers/scsi/pcmcia/nsp_cs.c                |   5 +-
>>>  10 files changed, 81 insertions(+), 77 deletions(-)
>>>
>>
>>
> 


-- 
Damien Le Moal
Western Digital Research