Re: [PATCH v1 3/5] gpio: max77620: Replace interrupt-enable array with bitmap

From: Andy Shevchenko
Date: Wed Jul 08 2020 - 04:44:27 EST


On Wed, Jul 8, 2020 at 11:30 AM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> There is no need to dedicate an array where a bitmap could be used.
> Let's replace the interrupt's enable-array with the enable-mask in order
> to improve the code a tad.

...

> +#include <linux/bitops.h>

> unsigned int irq_type[MAX77620_GPIO_NR];
> - bool irq_enabled[MAX77620_GPIO_NR];
> + unsigned long irq_enb_mask;

I would rather to move to DECLARE_BITMAP()
(the macro is defined in types.h IIRC)

--
With Best Regards,
Andy Shevchenko