Re: [PATCH] regmap: add missing dependency on SoundWire

[Pierre-Louis Bossart]

On 7/8/20 2:14 AM, Greg Kroah-Hartman wrote:
> On Tue, Jul 07, 2020 at 03:26:28PM -0500, Pierre-Louis Bossart wrote:
> > CONFIG_REGMAP is not selected when no other serial bus is supported.
> > It's largely academic since CONFIG_I2C is usually selected e.g. by
> > DRM, but still this can break randconfig so let's be explicit.
> >
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/base/regmap/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> > index 0fd6f97ee523..1d1d26b0d279 100644
> > --- a/drivers/base/regmap/Kconfig
> > +++ b/drivers/base/regmap/Kconfig
> > @@ -4,7 +4,7 @@
> >   # subsystems should select the appropriate symbols.
> >   
> >   config REGMAP
> > -	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
> > +	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SCCB || REGMAP_I3C)
>
> Any reason you didn't add it to the end of the list instead of adding it
> to the middle?

yes, I followed the config order in the same file:

grep config Kconfig
config REGMAP
config REGCACHE_COMPRESSED
config REGMAP_AC97
config REGMAP_I2C
config REGMAP_SLIMBUS
config REGMAP_SPI
config REGMAP_SPMI
config REGMAP_W1
config REGMAP_MMIO
config REGMAP_IRQ
config REGMAP_SOUNDWIRE
config REGMAP_SCCB
config REGMAP_I3C