Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

From: Paolo Bonzini
Date: Wed Jul 08 2020 - 09:30:20 EST


On 08/07/20 15:27, Xiaoyao Li wrote:
>>
>
> I'm ok with kvm_vcpu_after_set_cpuid().
>
> BTW there is an unknown for me regarding enter_smm(). Currently, it
> calls kvm_update_cpuid(). I'm not sure which part it really needs,
> update CPUID or update vcpu state based on CPUID?

It needs to update CPUID because it affects CR4.OSXSAVE among others.

Paolo