Re: [PATCH v1 4/5] gpio: max77620: Don't handle disabled interrupts

From: Andy Shevchenko
Date: Wed Jul 08 2020 - 11:31:41 EST


On Wed, Jul 8, 2020 at 1:54 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
> 08.07.2020 13:11, Andy Shevchenko ÐÐÑÐÑ:

...

> It should be unnecessary since we now see that the handle_nested_irq()
> checks whether interrupt was requested and if it wasn't, then particular
> GPIO interrupt will be treated as spurious [1]. The pending == 0
> condition is an extreme case, I don't think that there is a need to
> optimize it without any good reason.
>
> [1] https://elixir.bootlin.com/linux/v5.8-rc3/source/kernel/irq/chip.c#L485
>
> Hence it should be better to drop this patch.

Fine with me, thanks!

--
With Best Regards,
Andy Shevchenko