Re: [PATCH] usbip: Use fallthrough pseudo-keyword

[Shuah Khan]

On 7/8/20 9:39 AM, Joe Perches wrote:
> On 2020-07-08 07:35, Shuah Khan wrote:
> > On 7/7/20 7:56 PM, Joe Perches wrote:
> > > On Tue, 2020-07-07 at 14:06 -0600, Shuah Khan wrote:
> > > > On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote:
> > > > > Replace the existing /* fall through */ comments and its variants with
> > > > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > > > > fall-through markings when it is the case.
> > > > >
> > > > > [1] 
> > > > > https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through 
> > > >
> > > > Is fallthrough syntax supported on our min gcc version?
> > >
> > > No. Introduced in gcc 7.
> >
> > Gustavo,
> >
> > In which case, this patch would break usbip build on older gcc
> > revisions.
>
> No it will not. Comment fall through was introduced in gcc 7 and this 
> devolved into a do while 0

Ah thanks. I didn't know that. No concerns of patch to go in.

thanks,
--- Shuah