Re: [PATCH v4] nbd: Fix memory leak in nbd_add_socket

From: Eric Biggers
Date: Wed Jul 08 2020 - 16:32:08 EST


On Mon, Jun 29, 2020 at 09:23:49AM +0800, Zheng Bin wrote:
> When adding first socket to nbd, if nsock's allocation failed, the data
> structure member "config->socks" was reallocated, but the data structure
> member "config->num_connections" was not updated. A memory leak will occur
> then because the function "nbd_config_put" will free "config->socks" only
> when "config->num_connections" is not zero.
>
> Fixes: 03bf73c315ed ("nbd: prevent memory leak")
> Reported-by: syzbot+934037347002901b8d2a@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Zheng Bin <zhengbin13@xxxxxxxxxx>
> ---

Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>