Re: [PATCH] scsi: fcoe: add missed kfree() in an error path

[Jing Xiangfeng]

On 2020/7/7 19:38, Markus Elfring wrote:
> > fcoe_fdmi_info() misses to call kfree() in an error path.
> > Add the missed function call to fix it.
>
> I suggest to use an additional jump target for the completion
> of the desired exception handling.
>
>
> â
> > +++ b/drivers/scsi/fcoe/fcoe.c
> > @@ -830,6 +830,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev)
> >   		if (rc) {
> >   			printk(KERN_INFO "fcoe: Failed to retrieve FDMI "
> >   					"information from netdev.\n");
> > +			kfree(fdmi);
> >   			return;
> >   		}
>
> -			return;
> +			goto free_fdmi;
>
>
> How do you think about to apply any further coding style adjustments?

The local variable "fdmi" is invisible to the function.
See fcoe_fdmi_info().

	Thanks
> Regards,
> Markus
> .