Re: [PATCH] riscv: Enable ELF-ASLR for riscv

[Guo Ren]

On Thu, Jul 9, 2020 at 1:32 PM Alex Ghiti <alex@xxxxxxxx> wrote:
>
> Hi Guo,
>
> Le 7/9/20 Ã 12:38 AM, guoren@xxxxxxxxxx a Ãcrit :
> > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> >
> > Let riscv enable randomizes the stack, heap and binary images of
> > ELF binaries. Seems it's ok at all after qemu & chip test and
> > there is no founded side effect.
> >
> > So just simply select ARCH_HAS_ELF_RANDOMIZE :)
> >
> > Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> > Cc: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>
> > Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > Cc: Zong Li <zong.li@xxxxxxxxxx>
> > Cc: Greentime Hu <green.hu@xxxxxxxxx>
> > ---
> >   arch/riscv/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > index 91bfc6c..eed6647 100644
> > --- a/arch/riscv/Kconfig
> > +++ b/arch/riscv/Kconfig
> > @@ -20,6 +20,7 @@ config RISCV
> >       select ARCH_HAS_GIGANTIC_PAGE
> >       select ARCH_HAS_MMIOWB
> >       select ARCH_HAS_PTE_SPECIAL
> > +     select ARCH_HAS_ELF_RANDOMIZE
> >       select ARCH_HAS_SET_DIRECT_MAP
> >       select ARCH_HAS_SET_MEMORY
> >       select ARCH_HAS_STRICT_KERNEL_RWX if MMU
> >
>
> Actually it is already the case: ARCH_HAS_ELF_RANDOMIZE is already
> selected by ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT.
Oops :P, Thx for correcting, abandon the patch.

-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/