Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables

From: Sibi Sankar
Date: Thu Jul 09 2020 - 10:44:06 EST


On 2020-07-09 19:59, Bjorn Andersson wrote:
On Wed 08 Jul 19:22 PDT 2020, Steev Klimaszewski wrote:


On 7/2/20 3:46 PM, Sibi Sankar wrote:
> Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> ---


Hi Sibi,


Bjorn asked me to give this patch a whirl, and I have to say, I like it
but I'm not sure if I'm missing a dependency somewhere...


In 5.8.0-rc4, I'm seeing a couple probe defers

[ Â Â0.131341] cpu cpu0: _allocate_opp_table: Error finding interconnect
paths: -517

[ Â Â0.132694] cpu cpu4: _allocate_opp_table: Error finding interconnect
paths: -517

And then a bit later on,

[ Â Â0.625837] cpu cpu0: failed to get clock: -2


If these aren't anything to worry about, you can throw my Tested-by on

Tested-by: Steev Klimaszewski <steev@xxxxxxxx>


You need to enable:
CONFIG_INTERCONNECT=y
CONFIG_INTERCONNECT_QCOM=y
CONFIG_INTERCONNECT_QCOM_OSM_L3=m
CONFIG_INTERCONNECT_QCOM_SDM845=m

Steev had ^^ enabled but he was missing
the required cpufreq driver changes
available in linux-next.


With this I can see the interconnect_summary in debugfs change with the
CPU frequency.

Regards,
Bjorn

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.