Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node

From: Laxman Dewangan
Date: Thu Jul 09 2020 - 10:59:32 EST




On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote:
External email: Use caution opening links or attachments


The gpiochip_add_data() takes care of setting the of_node to the parent's
device of_node, hence there is no need to do it manually in the driver's
code. This patch corrects the parent's device pointer and removes the
unnecessary setting of the of_node.

Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>



Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>