Re: [PATCH v3 4/6] gpio: max77620: Don't shadow error code of platform_get_irq()

From: Laxman Dewangan
Date: Thu Jul 09 2020 - 11:02:23 EST




On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote:
External email: Use caution opening links or attachments


The platform_get_irq() returns a positive interrupt number on success and
negative error code on failure (zero shouldn't ever happen in practice, it
would produce a noisy warning). Hence let's return the error code directly
instead of overriding it with -ENODEV.

Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>



Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>