Re: [v2][PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

From: Andy Shevchenko
Date: Thu Jul 09 2020 - 14:31:19 EST


On Thu, Jul 2, 2020 at 2:07 PM Aaron Ma <aaron.ma@xxxxxxxxxxxxx> wrote:
>
> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
>
> brightness_enable is already checked at the beginning.
> Most new thinkpads are using GPU driver to control brightness now,
> print notice when enabled brightness control even when brightness_enable = 1.


> + } else if (!tp_features.bright_acpimode) {
> + pr_notice("thinkpad_acpi backlight interface not available\n");
> + return 1;
> }
>
> + pr_notice("thinkpad_acpi native brightness control enabled\n");

In both cases don't you see the duplication of module name in the messages?

--
With Best Regards,
Andy Shevchenko