Re: [PATCH AUTOSEL 5.7 11/53] btrfs: use kfree() in btrfs_ioctl_get_subvol_info()

From: Sasha Levin
Date: Thu Jul 09 2020 - 18:28:20 EST


On Thu, Jul 02, 2020 at 10:25:58AM +0200, David Sterba wrote:
On Wed, Jul 01, 2020 at 09:21:20PM -0400, Sasha Levin wrote:
From: Waiman Long <longman@xxxxxxxxxx>

[ Upstream commit b091f7fede97cc64f7aaad3eeb37965aebee3082 ]

In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
was incorrectly paired with kzfree(). According to David Sterba, there
isn't any sensitive information in the subvol_info that needs to be
cleared before freeing. So kzfree() isn't really needed, use kfree()
instead.

I don't think this patch is necessary for any stable tree, it's meant
only to ease merging a tree-wide patchset to rename kzfree. In btrfs
code there was no point using it so it's plain kfree.

I've dropped it, thanks!

--
Thanks,
Sasha