Re: [PATCH v5 6/6] PCI: uniphier: Use devm_platform_ioremap_resource_byname()

From: Kunihiko Hayashi
Date: Thu Jul 09 2020 - 20:54:31 EST


Hi Lorenzo,

This 6/6 patch has just been covered with the following patch:
https://patchwork.ozlabs.org/project/linux-pci/patch/20200708164013.5076-1-zhengdejin5@xxxxxxxxx/

As a result, my other patches conflict with this patch.
I'd like your comments in the patch 2/6, though,
should I rebase to pci/dwc and resend this series without 6/6?

Thank you,

On 2020/06/18 17:38, Kunihiko Hayashi wrote:
Use devm_platform_ioremap_resource_byname() to simplify the code a bit.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>f
---
drivers/pci/controller/dwc/pcie-uniphier.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c
index 8356dd3..233d624 100644
--- a/drivers/pci/controller/dwc/pcie-uniphier.c
+++ b/drivers/pci/controller/dwc/pcie-uniphier.c
@@ -456,8 +456,7 @@ static int uniphier_pcie_probe(struct platform_device *pdev)
if (IS_ERR(priv->pci.atu_base))
priv->pci.atu_base = NULL;
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link");
- priv->base = devm_ioremap_resource(dev, res);
+ priv->base = devm_platform_ioremap_resource_byname(pdev, "link");
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);


---
Best Regards
Kunihiko Hayashi