Re: [RFC PATCH v2] scsi: ufs-mediatek: add inline encryption support

From: Eric Biggers
Date: Fri Jul 10 2020 - 02:39:25 EST


Hi Stanley,

On Wed, Mar 04, 2020 at 10:21:02AM +0800, Stanley Chu wrote:
> Add inline encryption support to ufs-mediatek.
>
> The standards-compliant parts, such as querying the crypto capabilities
> and enabling crypto for individual UFS requests, are already handled by
> ufshcd-crypto.c, which itself is wired into the blk-crypto framework.
>
> However MediaTek UFS host requires a vendor-specific hce_enable operation
> to allow crypto-related registers being accessed normally in kernel.
> After this step, MediaTek UFS host can work as standard-compliant host
> for inline-encryption related functions.
>
> This patch is rebased to below repo and tag:
> Repo: https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git
> Tag: inline-encryption-v7
>
> Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 27 ++++++++++++++++++++++++++-
> drivers/scsi/ufs/ufs-mediatek.h | 1 +
> 2 files changed, 27 insertions(+), 1 deletion(-)

Now that the ufshcd-crypto patches this depends on are in 5.9/scsi-queue, could
you retest and resend this patch? It would be nice to have 5.9 support some
real hardware already. (I'm going to resend my patchset for ufs-qcom too.)

- Eric