RE: [PATCH v2 02/29] soc: Add Realtek DHC chip info driver for RTD1195 and RTD1295

From: Stanley Chang[æèå]
Date: Fri Jul 10 2020 - 03:55:48 EST


Hi Andreas,

I have reviewed this patch and tested in my local platforms (RTD1319/RTD1619/RTD1395).
And this patch is fine and it can work.

> -----Original Message-----
> From: Andreas FÃrber [mailto:afaerber@xxxxxxx]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@xxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; James
> Tai [æåå]; Stanley Chang[æèå]; Edgar Lee [ææè]; Andreas FÃrber
> Subject: [PATCH v2 02/29] soc: Add Realtek DHC chip info driver for RTD1195
> and RTD1295
>
> Add a soc bus driver to print chip model and revision details.
>
> Revisions from downstream drivers/soc/realtek/rtd{119x,129x}/rtk_chip.c.
>
> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
> ---
> v1 -> v2:
> * Added entry to MAINTAINERS
> * Changed chip_id and chip_rev from u32 to u16, based on reg field
> definitions
> * Added error return path for get_name for deferred probing, reordered
> code
>
> MAINTAINERS | 1 +
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/realtek/Kconfig | 13 +++
> drivers/soc/realtek/Makefile | 2 +
> drivers/soc/realtek/chip.c | 181
> +++++++++++++++++++++++++++++++++++
> 6 files changed, 199 insertions(+)

Tested-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
Reviewed-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>

Thanks,
Stanley