Re: [PATCH v6 0/5] clean up redundant 'kvm_run' parameters

[Paolo Bonzini]

On 10/07/20 09:32, Tianjia Zhang wrote:
> Hi Paolo,
> 
> Any opinion on this series patches? Can I help with this patchset ?

I was hoping to have some Tested-by, for now I'm queuing patches 1 and
2.  Thanks,

Paolo

> Thanks and best,
> Tianjia
> 
> On 2020/6/23 21:14, Tianjia Zhang wrote:
>> In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu'
>> structure. For historical reasons, many kvm-related function parameters
>> retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This
>> patch does a unified cleanup of these remaining redundant parameters.
>>
>> This series of patches has completely cleaned the architecture of
>> arm64, mips, ppc, and s390 (no such redundant code on x86). Due to
>> the large number of modified codes, a separate patch is made for each
>> platform. On the ppc platform, there is also a redundant structure
>> pointer of 'kvm_run' in 'vcpu_arch', which has also been cleaned
>> separately.
>>
>> ---
>> v6 changes:
>> ÂÂ Rearrange patch sets, only keep the unmerged patch.
>> ÂÂ rebase on mainline.
>>
>> v5 change:
>> ÂÂ ppc: fix for review.
>>
>> v4 change:
>> ÂÂ mips: fixes two errors in entry.c.
>>
>> v3 change:
>> ÂÂ Keep the existing `vcpu->run` in the function body unchanged.
>>
>> v2 change:
>> ÂÂ s390 retains the original variable name and minimizes modification.
>>
>> Tianjia Zhang (5):
>> ÂÂ KVM: s390: clean up redundant 'kvm_run' parameters
>> ÂÂ KVM: arm64: clean up redundant 'kvm_run' parameters
>> ÂÂ KVM: PPC: clean up redundant kvm_run parameters in assembly
>> ÂÂ KVM: MIPS: clean up redundant 'kvm_run' parameters
>> ÂÂ KVM: MIPS: clean up redundant kvm_run parameters in assembly
>>
>> Â arch/arm64/include/asm/kvm_coproc.hÂÂ |Â 12 +--
>> Â arch/arm64/include/asm/kvm_host.hÂÂÂÂ |Â 11 +--
>> Â arch/arm64/include/asm/kvm_mmu.hÂÂÂÂÂ |ÂÂ 2 +-
>> Â arch/arm64/kvm/arm.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 6 +-
>> Â arch/arm64/kvm/handle_exit.cÂÂÂÂÂÂÂÂÂ |Â 36 ++++----
>> Â arch/arm64/kvm/mmio.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 11 +--
>> Â arch/arm64/kvm/mmu.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 5 +-
>> Â arch/arm64/kvm/sys_regs.cÂÂÂÂÂÂÂÂÂÂÂÂ |Â 13 ++-
>> Â arch/mips/include/asm/kvm_host.hÂÂÂÂÂ |Â 32 ++------
>> Â arch/mips/kvm/emulate.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 59 +++++--------
>> Â arch/mips/kvm/entry.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 21 ++---
>> Â arch/mips/kvm/mips.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 14 ++--
>> Â arch/mips/kvm/trap_emul.cÂÂÂÂÂÂÂÂÂÂÂÂ | 114 +++++++++++---------------
>> Â arch/mips/kvm/vz.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 26 +++---
>> Â arch/powerpc/include/asm/kvm_ppc.hÂÂÂ |ÂÂ 2 +-
>> Â arch/powerpc/kvm/book3s_interrupts.SÂ |Â 22 +++--
>> Â arch/powerpc/kvm/book3s_pr.cÂÂÂÂÂÂÂÂÂ |ÂÂ 9 +-
>> Â arch/powerpc/kvm/booke.cÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 9 +-
>> Â arch/powerpc/kvm/booke_interrupts.SÂÂ |ÂÂ 9 +-
>> Â arch/powerpc/kvm/bookehv_interrupts.S |Â 10 +--
>> Â arch/s390/kvm/kvm-s390.cÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 23 ++++--
>> Â 21 files changed, 188 insertions(+), 258 deletions(-)
>>
>