Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

From: Cyrill Gorcunov
Date: Fri Jul 10 2020 - 05:37:41 EST


On Fri, Jul 10, 2020 at 11:05:11AM +0200, Rasmus Villemoes wrote:
> >> I deliberately drop the ifdef in the eventpoll.h header rather than
> >> replace with KCMP_SYSCALL; it's harmless to declare a function that
> >> isn't defined anywhere.
> >
> > Could you please point why setting #fidef KCMP_SYSCALL in eventpoll.h
> > is not suitable?
>
> It's just from a general "avoid ifdef clutter if possible" POV. The
> conditional declaration of the function doesn't really serve any
> purpose.

OK, thanks for explanation.