Re: [PATCH V7 15/15] perf script: Show text poke address symbol

[Adrian Hunter]

On 10/07/20 2:34 pm, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 12, 2020 at 03:19:22PM +0300, Adrian Hunter escreveu:
>> It is generally more useful to show the symbol with an address. In this
>> case, the print function requires the 'machine' which means changing
>> callers to provide it as a parameter. It is optional because most events
>> do not need it and the callers that matter can provide it.
> 
> I'm just inverting the order of the parameters for
> perf_event__fprintf(), to keep as the first arg the pointer to the type
> that is the prefix for the function, i.e. instead of:
> 
> size_t perf_event__fprintf_text_poke(struct machine *machine,
> 				     union perf_event *event, FILE *fp)
> 
> I'll make it be:
> 
> size_t perf_event__fprintf_text_poke(union perf_event *event,
> 				     struct machine *machine,FILE *fp)
> 
> Ok?

Yup! Thank you!