On Fri, Jul 10, 2020 at 02:00:32PM -0700, Scott Branden wrote:Yes, but there's no requirement that *buf need to be NULL when calling this function.
Did it give you a stack backtrace?@@ -950,8 +951,8 @@ int kernel_read_file(struct file *file, void **buf, loff_t *size,The assumption that *buf is always NULL when id !=
goto out;
}
- if (id != READING_FIRMWARE_PREALLOC_BUFFER)
- *buf = vmalloc(i_size);
+ if (!*buf)
READING_FIRMWARE_PREALLOC_BUFFER doesn't appear to be correct.
I get unhandled page faults due to this change on boot.