Re: [PATCH v6 09/17] x86/static_call: Add out-of-line static call implementation

From: Peter Zijlstra
Date: Sat Jul 11 2020 - 06:12:18 EST


On Fri, Jul 10, 2020 at 06:13:31PM -0400, Steven Rostedt wrote:
> On Fri, 10 Jul 2020 15:38:40 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> >
> > Add the x86 out-of-line static call implementation. For each key, a
> > permanent trampoline is created which is the destination for all static
> > calls for the given key. The trampoline has a direct jump which gets
> > patched by static_call_update() when the destination function changes.
>
> FYI, I get the following warnings after applying this patch.
>
> /work/git/linux-test.git/arch/x86/kernel/static_call.c: In function â__static_call_transformâ:
> /work/git/linux-test.git/arch/x86/kernel/static_call.c:9:43: warning: passing argument 2 of âtext_gen_insnâ makes pointer from integer without a cast [-Wint-conversion]
> 9 | const void *code = text_gen_insn(opcode, (long)insn, (long)func);
> | ^~~~~~~~~~
> | |
> | long int

Hurmph, shows I haven't build the individual patches in a while I
suppose. It was fixed in the next patch.

Fixed it up, thanks!