Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

[Richard Cochran]

On Fri, Jul 10, 2020 at 01:58:44PM -0700, Jakub Kicinski wrote:
> On Fri, 10 Jul 2020 11:41:25 -0400 min.li.xe@xxxxxxxxxxx wrote:
> > From: Min Li <min.li.xe@xxxxxxxxxxx>
> > 
> > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33.
> > It will create a debugfs directory called idtptp{x} and x is the ptp index.
> > Three inerfaces are present, which are cmd, help and regs. help is read
> > only and will display a brief help message. regs is read only amd will show
> > all register values. cmd is write only and will accept certain commands.
> > Currently, the accepted commands are combomode to set comobo mode and write
> > to write up to 4 registers.
> > 
> > Signed-off-by: Min Li <min.li.xe@xxxxxxxxxxx>
> 
> No private configuration interfaces in debugfs, please.

I suggested to Min to use debugfs for device-specific configuration
that would be out of place in the generic PTP Hardware Clock
interface.

> If what you're exposing is a useful feature it deserves a proper 
> uAPI interface.

Can you expand on what you mean by "proper uAPI interface" please?

Thanks,
Richard