Re: [PATCH RFC] leds: Add support for per-LED device triggers

From: Marek Behun
Date: Sun Jul 12 2020 - 19:18:46 EST


On Mon, 13 Jul 2020 01:15:44 +0200
Marek Behun <marek.behun@xxxxxx> wrote:

> On Mon, 13 Jul 2020 00:38:21 +0200
> OndÅej Jirman <megous@xxxxxxxxxx> wrote:
>
> > So after trying to use this, this seems to disallow the use of multiple HW
> > triggers per LED. That's fine by me, because using one HW sysfs configured
> > trigger per LED that use case is my proposal, but is it desireable in general?
>
> Why? If you register one LED and several triggers, all sharing the same
> trigger_type pointer, I think it should work.
>
> Marek

The problem arises when I have two LEDs and two HW triggers, and the
hardware allows setting one HW trigger on both LEDs and other HW
trigger only on one LED. But this could simply be ignored - the
set_trigger function could simply return -ENOTSUPP or something.

Marek