Re: [PATCH 2/2] cpufreq: tegra186: Simplify probe return path

From: Viresh Kumar
Date: Sun Jul 12 2020 - 23:28:08 EST


On 12-07-20, 11:06, Jon Hunter wrote:
> We always put the reference to BPMP device on exit of the Tegra186
> CPUFREQ driver and so there is no need to have separate exit paths
> for success and failure. Therefore, simplify the probe return path
> in the Tegra186 CPUFREQ driver by combining the success and failure
> paths.
>
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> ---
> drivers/cpufreq/tegra186-cpufreq.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c
> index c44190ce3f03..bf8cab357277 100644
> --- a/drivers/cpufreq/tegra186-cpufreq.c
> +++ b/drivers/cpufreq/tegra186-cpufreq.c
> @@ -231,15 +231,9 @@ static int tegra186_cpufreq_probe(struct platform_device *pdev)
> }
> }
>
> - tegra_bpmp_put(bpmp);
> -
> tegra186_cpufreq_driver.driver_data = data;
>
> err = cpufreq_register_driver(&tegra186_cpufreq_driver);
> - if (err)
> - return err;
> -
> - return 0;
>
> put_bpmp:
> tegra_bpmp_put(bpmp);

Applied. Thanks.

--
viresh