Re: [PATCH] ARM: dts: vf610-zii-ssmb-dtu: Pass "no-sdio"/"no-sd" properties

From: Shawn Guo
Date: Mon Jul 13 2020 - 02:36:28 EST


On Sat, Jul 04, 2020 at 08:16:10PM -0700, Chris Healy wrote:
> esdhc0 is connected to an eMMC, so it is safe to pass the "no-sdio"/"no-sd"
> properties.
>
> esdhc1 is wired to a standard SD socket, so pass the "no-sdio" property.
>
> Signed-off-by: Chris Healy <cphealy@xxxxxxxxx>

I would suggest something like below for patch subject.

ARM: dts: vf610-zii-ssmb-dtu: Add no-sdio/no-sd properties

Also the patch doesn't apply to my branch.

Shawn

> ---
> arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index 0bb3dcff0b79..7d4ddfb6b5b5 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -81,6 +81,8 @@
> non-removable;
> no-1-8-v;
> keep-power-in-suspend;
> + no-sdio;
> + no-sd;
> status = "okay";
> };
>
> @@ -88,6 +90,7 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1>;
> bus-width = <4>;
> + no-sdio;
> status = "okay";
> };
>
> --
> 2.21.3