Re: [PATCH v10 04/15] perf evlist: introduce control file descriptors

[Alexey Budankov]

On 13.07.2020 6:13, Namhyung Kim wrote:
> Hello,
> 
> On Wed, Jul 8, 2020 at 4:47 PM Alexey Budankov
> <alexey.budankov@xxxxxxxxxxxxxxx> wrote:
>>
>>
>> Define and initialize control file descriptors.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@xxxxxxxxxxxxxxx>
>> ---
>>  tools/perf/util/evlist.c | 3 +++
>>  tools/perf/util/evlist.h | 5 +++++
>>  2 files changed, 8 insertions(+)
>>
>> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
>> index bcbe0cb8482e..36eb50aba1f5 100644
>> --- a/tools/perf/util/evlist.c
>> +++ b/tools/perf/util/evlist.c
>> @@ -63,6 +63,9 @@ void evlist__init(struct evlist *evlist, struct perf_cpu_map *cpus,
>>         perf_evlist__set_maps(&evlist->core, cpus, threads);
>>         evlist->workload.pid = -1;
>>         evlist->bkw_mmap_state = BKW_MMAP_NOTREADY;
>> +       evlist->ctl_fd.fd = -1;
>> +       evlist->ctl_fd.ack = -1;
>> +       evlist->ctl_fd.pos = -1;
>>  }
>>
>>  struct evlist *evlist__new(void)
>> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
>> index 38901c0d1599..2caf19fb87a8 100644
>> --- a/tools/perf/util/evlist.h
>> +++ b/tools/perf/util/evlist.h
>> @@ -74,6 +74,11 @@ struct evlist {
>>                 pthread_t               th;
>>                 volatile int            done;
>>         } thread;
>> +       struct {
>> +               int     fd;
>> +               int     ack;
>> +               int     pos;
>> +       } ctl_fd;
> 
> Could you please add brief descriptions for each field
> in the comment?  It's not obvious to me other than fd.

Ok. In v11.

Alexei