Re: [PATCH] regulator: cros-ec: Constify cros_ec_regulator_voltage_ops

From: Pi-Hsun Shih
Date: Mon Jul 13 2020 - 04:56:35 EST


Acked-by: Pi-Hsun Shih <pihsun@xxxxxxxxxxxx>

On Sat, Jul 11, 2020 at 7:44 PM Rikard Falkeborn
<rikard.falkeborn@xxxxxxxxx> wrote:
>
> It is never modified, so make it const to allow the compiler to put it
> in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>
> ---
> drivers/regulator/cros-ec-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/cros-ec-regulator.c b/drivers/regulator/cros-ec-regulator.c
> index 35f97246bc48..eeed5aac3f32 100644
> --- a/drivers/regulator/cros-ec-regulator.c
> +++ b/drivers/regulator/cros-ec-regulator.c
> @@ -142,7 +142,7 @@ static int cros_ec_regulator_set_voltage(struct regulator_dev *dev, int min_uV,
> sizeof(cmd), NULL, 0);
> }
>
> -static struct regulator_ops cros_ec_regulator_voltage_ops = {
> +static const struct regulator_ops cros_ec_regulator_voltage_ops = {
> .enable = cros_ec_regulator_enable,
> .disable = cros_ec_regulator_disable,
> .is_enabled = cros_ec_regulator_is_enabled,
> --
> 2.27.0
>