Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

From: Mark Rutland
Date: Mon Jul 13 2020 - 08:26:43 EST


On Fri, Jul 10, 2020 at 03:57:05PM +0200, Christoph Hellwig wrote:
> Add helpers to wraper the get_fs/set_fs magic for undoing any damange
> done by set_fs(KERNEL_DS). There is no real functional benefit, but this
> documents the intent of these calls better, and will allow stubbing the
> functions out easily for kernels builds that do not allow address space
> overrides in the future.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> arch/arm64/kernel/sdei.c | 2 +-
> arch/m68k/include/asm/tlbflush.h | 12 ++++++------
> arch/mips/kernel/unaligned.c | 27 +++++++++++++--------------
> arch/nds32/mm/alignment.c | 7 +++----
> arch/sh/kernel/traps_32.c | 18 ++++++++----------
> drivers/firmware/arm_sdei.c | 5 ++---
> include/linux/uaccess.h | 18 ++++++++++++++++++
> kernel/events/callchain.c | 5 ++---
> kernel/events/core.c | 5 ++---
> kernel/kthread.c | 5 ++---
> kernel/stacktrace.c | 5 ++---
> mm/maccess.c | 22 ++++++++++------------
> 12 files changed, 69 insertions(+), 62 deletions(-)

The perf core and arm64/sdei bits look sound. FWIW:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.