Re: [PATCH v11 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records

From: Rafael J. Wysocki
Date: Mon Jul 13 2020 - 09:38:42 EST


On Mon, Jul 13, 2020 at 3:33 PM Shiju Jose <shiju.jose@xxxxxxxxxx> wrote:
>
> Hi Rafael,
>
> >-----Original Message-----
> >From: Rafael J. Wysocki [mailto:rafael@xxxxxxxxxx]
> >Sent: 13 July 2020 12:18
> >To: Shiju Jose <shiju.jose@xxxxxxxxxx>
> >Cc: linux-acpi@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-
> >kernel@xxxxxxxxxxxxxxx; rjw@xxxxxxxxxxxxx; helgaas@xxxxxxxxxx;
> >bp@xxxxxxxxx; james.morse@xxxxxxx; lenb@xxxxxxxxxx;
> >tony.luck@xxxxxxxxx; dan.carpenter@xxxxxxxxxx;
> >zhangliguang@xxxxxxxxxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx;
> >Wangkefeng (OS Kernel Lab) <wangkefeng.wang@xxxxxxxxxx>;
> >jroedel@xxxxxxx; Linuxarm <linuxarm@xxxxxxxxxx>; yangyicong
> ><yangyicong@xxxxxxxxxx>; Jonathan Cameron
> ><jonathan.cameron@xxxxxxxxxx>; tanxiaofei <tanxiaofei@xxxxxxxxxx>
> >Subject: Re: [PATCH v11 1/2] ACPI / APEI: Add a notifier chain for unknown
> >(vendor) CPER records
> >
> >On Mon, Jul 13, 2020 at 10:35 AM Shiju Jose <shiju.jose@xxxxxxxxxx>
> >wrote:
> >>
> >> Hi Rafael, Hi James,
> >>
> >> Can you help to merge this patch because I added and tested all the
> >suggestions from James.
> >
> >I could apply the [1/2] in principle, but I need an ACK for the [2/2] from the
> >PCI side.
> >
> >That said, it looks like the [1/2] is a James' patch that you are sending with
> >some changes made by you.
> James added following changes on top of the original patch(V10) by me,
> [ Removed kfifo and ghes_gdata_pool. Expanded commit message ]
> I had confusion how the S-o-b tag to be added for James's changes in the V11 patch posted.

So James should have sent the patch with his S-o-b under it.

You cannot add S-o-b for somebody else to any patches. You can only
add your S-o-b to somebody else's patch if you have made any changes
on top of the original.

In case you want to make a record of somebody else's contribution to
your patch, you can use the Co-developed-by tag.

Thanks!