Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type

[Daniel Lezcano]

On 13/07/2020 19:01, Thara Gopinath wrote:
> 
> 
> On 7/13/20 11:05 AM, Daniel Lezcano wrote:
>> On 10/07/2020 15:51, Thara Gopinath wrote:
>>> Extend thermal trip point type property to include "cold" trip type
>>> indicating point in the temperature domain below which a warming action
>>> must be intiated.
>>>
>>> Signed-off-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx>
>>> ---
>>> Â Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>>> Â 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> index f78bec19ca35..1689d9ba1471 100644
>>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> @@ -87,6 +87,7 @@ Required properties:
>>> ÂÂÂÂÂ "active":ÂÂÂ A trip point to enable active cooling
>>> ÂÂÂÂÂ "passive":ÂÂÂ A trip point to enable passive cooling
>>> ÂÂÂÂÂ "hot":ÂÂÂÂÂÂÂ A trip point to notify emergency
>>> +ÂÂÂ "cold":ÂÂÂÂÂÂÂ A trip point to enable warming
>>> ÂÂÂÂÂ "critical":ÂÂÂ Hardware not reliable.
>>> ÂÂÂ Type: string
>>
>>
>> thermal.txt should have been removed. Perhaps, a patch is missing. The
>> thermal.txt has been converted into 3 yaml schema.
>>
>> The change should be in thermal-zones.yaml.
> 
> Hi Daniel..
> 
> Thanks for the review. My bad.. I will fix this in the next version.
> I can send a patch removing thermal.txt as well

Yes, sure.

Thanks


-- 
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog