Re: [PATCH net-next] rtnetlink: Fix memory(net_device) leak when ->newlink fails
From: David Miller
Date: Mon Jul 13 2020 - 15:02:11 EST
From: Weilong Chen <chenweilong@xxxxxxxxxx>
Date: Mon, 13 Jul 2020 15:55:28 +0800
> When vlan_newlink call register_vlan_dev fails, it might return error
> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should
> free the memory. But currently rtnl_newlink only free the memory which
> state is NETREG_UNINITIALIZED.
...
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx>
This needs a Fixes: tag.
Also, can't this bug happen in mainline too? It's a bug fix and therefore
should target 'net' instead of 'net-next'.