Re: [PATCH v7 1/6] ACPI: Support Generic Initiator only domains

From: kernel test robot
Date: Mon Jul 13 2020 - 15:44:46 EST


Hi Jonathan,

I love your patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on tip/x86/core driver-core/driver-core-testing linus/master tip/x86/mm v5.8-rc5 next-20200713]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Jonathan-Cameron/ACPI-Support-Generic-Initiator-proximity-domains/20200714-000539
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/acpi/numa/srat.c: In function 'acpi_parse_gi_affinity':
>> drivers/acpi/numa/srat.c:386:9: error: too many arguments to function 'acpi_map_pxm_to_node'
386 | node = acpi_map_pxm_to_node(gi_affinity->proximity_domain, true);
| ^~~~~~~~~~~~~~~~~~~~
drivers/acpi/numa/srat.c:55:5: note: declared here
55 | int acpi_map_pxm_to_node(int pxm)
| ^~~~~~~~~~~~~~~~~~~~

vim +/acpi_map_pxm_to_node +386 drivers/acpi/numa/srat.c

370
371 static int __init
372 acpi_parse_gi_affinity(union acpi_subtable_headers *header,
373 const unsigned long end)
374 {
375 struct acpi_srat_generic_affinity *gi_affinity;
376 int node;
377
378 gi_affinity = (struct acpi_srat_generic_affinity *)header;
379 if (!gi_affinity)
380 return -EINVAL;
381 acpi_table_print_srat_entry(&header->common);
382
383 if (!(gi_affinity->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED))
384 return -EINVAL;
385
> 386 node = acpi_map_pxm_to_node(gi_affinity->proximity_domain, true);
387 if (node == NUMA_NO_NODE || node >= MAX_NUMNODES) {
388 pr_err("SRAT: Too many proximity domains.\n");
389 return -EINVAL;
390 }
391 node_set(node, numa_nodes_parsed);
392 node_set_state(node, N_GENERIC_INITIATOR);
393
394 return 0;
395 }
396

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip