Re: [PATCH] rculist: Fix _list_check_srcu() macro

From: Paul E. McKenney
Date: Mon Jul 13 2020 - 17:26:27 EST


On Tue, Jul 14, 2020 at 02:43:16AM +0530, Madhuparna Bhowmik wrote:
> On Mon, Jul 13, 2020 at 02:02:44PM -0700, Paul E. McKenney wrote:
> > On Mon, Jul 13, 2020 at 11:18:46PM +0530, madhuparnabhowmik10@xxxxxxxxx wrote:
> > > From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
> > >
> > > This patch fixes the macro _list_check_srcu() for CONFIG_PROVE_RCU_LIST =
> > > False.
> > >
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
> >
> > Thank you, Madhuparna! I am folding this into your original, but
> > with lowercase "true".
> >
> I am really sorry and thanks for applying this with the correction.

No worries! Just thought that I should mention it in case there was
some subtle reason why TRUE was needed in this case. ;-)

Thanx, Paul

> > > ---
> > > include/linux/rculist.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/rculist.h b/include/linux/rculist.h
> > > index 516b4feb2682..a435ad62b90b 100644
> > > --- a/include/linux/rculist.h
> > > +++ b/include/linux/rculist.h
> > > @@ -73,7 +73,7 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)
> > > #define __list_check_rcu(dummy, cond, extra...) \
> > > ({ check_arg_count_one(extra); })
> > >
> > > -#define __list_check_srcu(cond)
> > > +#define __list_check_srcu(cond) TRUE
> > > #endif
> > >
> > > /*
> > > --
> > > 2.17.1
> > >