Re: [PATCH] erofs: Replace HTTP links with HTTPS ones

From: Gao Xiang
Date: Mon Jul 13 2020 - 21:22:59 EST


On Mon, Jul 13, 2020 at 03:09:44PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>

Looks good to me,
Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxx>

(Will apply later with other potential patches...)

Thanks,
Gao Xiang