Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

[Xu Yilun]

On Mon, Jul 13, 2020 at 07:36:26AM -0700, Tom Rix wrote:
> 
> > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> >  #define PCIE_DEVICE_ID_PF_INT_5_X	0xBCBD
> >  #define PCIE_DEVICE_ID_PF_INT_6_X	0xBCC0
> >  #define PCIE_DEVICE_ID_PF_DSC_1_X	0x09C4
> > +#define PCIE_DEVICE_ID_INTEL_PAC_N3000	0x0B30
> 
> My point about consistency.  These are all intel  and all should have their pf parts removed.
> 
>  #define PCIE_DEVICE_ID_INTEL_INT_5_X	0xBCBD
>  #define PCIE_DEVICE_ID_INTEL_INT_6_X	0xBCC0
>  #define PCIE_DEVICE_ID_INTEL_DSC_1_X	0x09C4
> 
> Let's revisit this for the d5005.

I agree that we should be consistent on the naming. I think we could
reconsider the naming of previous cards and submit a new patch for them.

> 
> trix
>