Re: [PATCH 2/5] spi: lpspi: add NULL check when probe device

From: Markus Elfring
Date: Tue Jul 14 2020 - 04:48:33 EST


â
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -841,6 +841,11 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
> u32 temp;
> bool is_slave;
>
> + if (!np && !lpspi_platform_info) {
> + dev_err(&pdev->dev, "can't get the platform data\n");
> + return -EINVAL;
> + }
â

How do you think about to combine these null pointer checks by the logical
operator âorâ instead of âandâ?

Regards,
Markus