Re: [PATCH] net: xilinx: fix potential NULL dereference in temac_probe()

From: Markus Elfring
Date: Tue Jul 14 2020 - 05:43:24 EST

Next message: Mark Brown: "Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare"
Previous message: Kalle Valo: "Re: [PATCH] brcmfmac: set timeout value when configuring power save"
In reply to: Florian Fainelli: "Re: [PATCH] net: xilinx: fix potential NULL dereference in temac_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> If you use devm_ioremap_resource() you can remove the !res check
> entirely which would be equally acceptable as a fix.

Would you like to use the wrapper function âdevm_platform_get_and_ioremap_resourceâ then?
https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/base/platform.c#L66
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?id=0dc589da873b58b70f4caf4b070fb0cf70fdd1dc#n66

Regards,
Markus

Next message: Mark Brown: "Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare"
Previous message: Kalle Valo: "Re: [PATCH] brcmfmac: set timeout value when configuring power save"
In reply to: Florian Fainelli: "Re: [PATCH] net: xilinx: fix potential NULL dereference in temac_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]